[vlc-commits] msi: improve 64-bit support

Ludovic Fauvet git at videolan.org
Thu Feb 14 13:48:30 CET 2013


vlc | branch: master | Ludovic Fauvet <etix at videolan.org> | Wed Feb 13 18:24:30 2013 +0100| [28c8b02b2d419d6992f041b070ccc06de0d980b7] | committer: Rafaël Carré

msi: improve 64-bit support

Signed-off-by: Rafaël Carré <funman at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=28c8b02b2d419d6992f041b070ccc06de0d980b7
---

 extras/package/win32/msi/config.wxi.in |    2 ++
 extras/package/win32/msi/product.wxs   |    7 ++++---
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/extras/package/win32/msi/config.wxi.in b/extras/package/win32/msi/config.wxi.in
index 0baa9a5..5139ecc 100644
--- a/extras/package/win32/msi/config.wxi.in
+++ b/extras/package/win32/msi/config.wxi.in
@@ -23,9 +23,11 @@
     <?if $(var.Platform) = "x64" ?>
         <?define Win64 = "yes" ?>
         <?define PlatformString = "64-bit"?>
+        <?define PlatformProgramFilesFolder = "ProgramFiles64Folder" ?>
     <?else ?>
         <?define Win64 = "no" ?>
         <?define PlatformString = "32-bit"?>
+        <?define PlatformProgramFilesFolder = "ProgramFilesFolder" ?>
     <?endif ?>
 
     <?define AppFolder = "VLC" ?>
diff --git a/extras/package/win32/msi/product.wxs b/extras/package/win32/msi/product.wxs
index 149e72c..14e10ad 100644
--- a/extras/package/win32/msi/product.wxs
+++ b/extras/package/win32/msi/product.wxs
@@ -36,7 +36,8 @@
             InstallPrivileges='elevated'
             InstallScope='perMachine'
             InstallerVersion='200'
-            Compressed='yes'/>
+            Compressed='yes'
+            Platforms='$(var.Platform)'/>
 
         <MajorUpgrade Schedule="afterInstallInitialize" DowngradeErrorMessage="A later version of [ProductName] is already installed. Setup will now exit."/>
 
@@ -55,7 +56,7 @@
         <Property Id="ApplicationFolderName" Value="$(var.Manufacturer)\$(var.AppFolder)" />
         <Property Id="WixAppFolder" Value="WixPerMachineFolder" />
         <Property Id="APPLICATIONFOLDER">
-            <RegistrySearch Id="FindInstallRegDir" Type="raw" Root="HKLM" Key="Software\VideoLAN\VLC" Name="InstallDir" />
+            <RegistrySearch Id="FindInstallRegDir" Type="raw" Root="HKLM" Win64="$(var.Win64)" Key="Software\VideoLAN\VLC" Name="InstallDir" />
         </Property>
 
         <WixVariable Id="WixUISupportPerUser" Value="0" />
@@ -65,7 +66,7 @@
         <Media Id='1' Cabinet='product.cab' EmbedCab='yes' CompressionLevel="high" />
 
         <Directory Id='TARGETDIR' Name='SourceDir'>
-            <Directory Id='ProgramFilesFolder' Name='PFiles'>
+            <Directory Id='$(var.PlatformProgramFilesFolder)' Name='PFiles'>
                 <Directory Id='VideoLANFolder' Name='$(var.Manufacturer)'>
                     <Directory Id='APPLICATIONFOLDER' Name='$(var.AppFolder)' FileSource="$(var.SourceDir)">
 



More information about the vlc-commits mailing list