[vlc-commits] omxil: Ignore a codec that we know we don't work well with

[Martin Storsjö]

vlc | branch: master | Martin Storsjö <martin at martin.st> | Mon Feb 25 22:32:46 2013 +0200| [9dabc0a9f9c825d19b6aea8b108abb475d9d6cbb] | committer: Martin Storsjö

omxil: Ignore a codec that we know we don't work well with

This still keeps the mapping for VC1 and WMV3 that works fine on
e.g. Samsung Galaxy S3, without negatively affecting other devices
that expose decoders with this role but that we don't work well
with.

Signed-off-by: Martin Storsjö <martin at martin.st>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9dabc0a9f9c825d19b6aea8b108abb475d9d6cbb
---

 modules/codec/omxil/omxil.c |    6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/modules/codec/omxil/omxil.c b/modules/codec/omxil/omxil.c
index 8adcb42..8f35c6c 100644
--- a/modules/codec/omxil/omxil.c
+++ b/modules/codec/omxil/omxil.c
@@ -1007,6 +1007,12 @@ loaded:
          * using SW codecs is usually more than fast enough for MP3.) */
         if (!strcmp(p_sys->ppsz_components[i], "OMX.SEC.MP3.Decoder"))
             continue;
+        /* This codec should be able to handle both VC1 and WMV3, but
+         * for VC1 it doesn't output any buffers at all (in the way we use
+         * it) and for WMV3 it outputs plain black buffers. Thus ignore
+         * it until we can make it work properly. */
+        if (!strcmp(p_sys->ppsz_components[i], "OMX.Nvidia.vc1.decode"))
+            continue;
 #endif
         omx_error = InitialiseComponent(p_dec, p_sys->ppsz_components[i],
                                         &p_sys->omx_handle);