[vlc-commits] npmac: work-around our CoreAnimation implementation which doesn' t support invalidation yet

Felix Paul Kühne git at videolan.org
Fri Jan 4 12:41:29 CET 2013


npapi-vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Fri Jan  4 12:41:02 2013 +0100| [678fb74b93395ca779bf8e89e6a4ed5145af7108] | committer: Felix Paul Kühne

npmac: work-around our CoreAnimation implementation which doesn't support invalidation yet

Fixes vout within Firefox and Chrome

> http://git.videolan.org/gitweb.cgi/npapi-vlc.git/?a=commit;h=678fb74b93395ca779bf8e89e6a4ed5145af7108
---

 npapi/support/npmac.cpp |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/npapi/support/npmac.cpp b/npapi/support/npmac.cpp
index e11d5c2..7163f6e 100644
--- a/npapi/support/npmac.cpp
+++ b/npapi/support/npmac.cpp
@@ -438,6 +438,7 @@ NPError    Private_New(NPMIMEType pluginType, NPP instance, uint16_t mode, int16
             return NPERR_INCOMPATIBLE_VERSION_ERROR;
         }
 
+        /* FIXME by implementing CoreAnimation invalidation
         NPBool supportsInvalidatingCoreAnimation = FALSE;
         err = NPN_GetValue(instance, NPNVsupportsInvalidatingCoreAnimationBool, &supportsInvalidatingCoreAnimation);
         if (err != NPERR_NO_ERROR || !supportsInvalidatingCoreAnimation)
@@ -449,14 +450,14 @@ NPError    Private_New(NPMIMEType pluginType, NPP instance, uint16_t mode, int16
                 fprintf(stderr, "Error in New: couldn't activate Invalidating CoreAnimation drawing model\n");
                 return NPERR_INCOMPATIBLE_VERSION_ERROR;
             }
-        } else {
+        } else {*/
             fprintf(stderr, "New: falling back to non-invalidating CoreAnimation drawing, since invalidation is not supported\n");
             err = NPN_SetValue(instance, NPPVpluginDrawingModel, (void*)NPDrawingModelCoreAnimation);
             if (err != NPERR_NO_ERROR) {
                 fprintf(stderr, "Error in New: couldn't activate CoreAnimation drawing model\n");
                 return NPERR_INCOMPATIBLE_VERSION_ERROR;
             }
-        }
+        //}
     }
 
     NPBool supportsCocoaEvents = FALSE;



More information about the vlc-commits mailing list