[vlc-commits] Using delete in this context is against the COM rules

Ludovic Fauvet git at videolan.org
Mon Jan 14 17:57:47 CET 2013


npapi-vlc | branch: master | Ludovic Fauvet <etix at videolan.org> | Mon Jan 14 15:55:02 2013 +0100| [46a7255a01f72d5aec0df8b434f2d5e79b299230] | committer: Ludovic Fauvet

Using delete in this context is against the COM rules

This also kills warnings (see #7980).
Thanks to jacek from #mingw-w64

> http://git.videolan.org/gitweb.cgi/npapi-vlc.git/?a=commit;h=46a7255a01f72d5aec0df8b434f2d5e79b299230
---

 activex/vlccontrol2.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/activex/vlccontrol2.h b/activex/vlccontrol2.h
index 42c1f58..f89d4b7 100644
--- a/activex/vlccontrol2.h
+++ b/activex/vlccontrol2.h
@@ -303,9 +303,9 @@ public:
         _p_vlcmarquee(new VLCMarquee(p)), _p_vlclogo(new VLCLogo(p)),
         _p_vlcdeint(new VLCDeinterlace(p)) { }
     virtual ~VLCVideo() {
-        delete _p_vlcmarquee;
-        delete _p_vlclogo;
-        delete _p_vlcdeint;
+        _p_vlcmarquee->Release();
+        _p_vlclogo->Release();
+        _p_vlcdeint->Release();
     }
 
     // IVLCVideo methods



More information about the vlc-commits mailing list