[vlc-commits] Fix corrupted rendering of EIA-608 captions

[Devin Heitmueller]

vlc | branch: master | Devin Heitmueller <dheitmueller at kernellabs.com> | Sun Jan 13 16:53:05 2013 -0500| [b8d9f708c6e5c4c443bd732f739529dee99cdef8] | committer: Rafaël Carré

Fix corrupted rendering of EIA-608 captions

When we moved the code to use the legacy method *or* the new method,
we lost the functionality that actually initialized the memory allocated
for the entire subpicture region (including the part where captions
weren't being rendered.

This was most obvious when regression testing on OSX, where it
resulted in old captions continuing to appear on screen even
after being cleared, or garbage in the render buffer.

Add a line that effectively zeros out the buffer prior to use.

Signed-off-by: Rafaël Carré <funman at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b8d9f708c6e5c4c443bd732f739529dee99cdef8
---

 modules/text_renderer/freetype.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/modules/text_renderer/freetype.c b/modules/text_renderer/freetype.c
index 6389435..4592c25 100644
--- a/modules/text_renderer/freetype.c
+++ b/modules/text_renderer/freetype.c
@@ -1180,6 +1180,7 @@ static inline int RenderAXYZ( filter_t *p_filter,
 
     if (p_region->b_renderbg) {
         /* Render the background just under the text */
+        FillPicture( p_picture, 0x00, 0x00, 0x00, 0x00 );
         RenderBackground(p_region, p_line_head, p_bbox, i_margin, p_picture, i_text_width,
                          ExtractComponents, BlendPixel);
     } else {