[vlc-commits] dbus: Standardise property getters

Alex Merry git at videolan.org
Tue Jan 29 17:13:17 CET 2013


vlc | branch: master | Alex Merry <dev at randomguy3.me.uk> | Tue Jan 29 00:55:21 2013 +0000| [6ae4c72da0c9b94b5f6c52b7c13a11166cf5b8c2] | committer: Mirsal Ennaime

dbus: Standardise property getters

There was a lot of repeated code, some of which properly checked return
values and some of which didn't.  This is all replaced and folded into
the GetProperty function of each interface.

A side-effect is that it should be more efficient (we only check the
interface argument once instead of once for each property, and there
should be a smaller overall code size).

Signed-off-by: Mirsal Ennaime <mirsal at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=6ae4c72da0c9b94b5f6c52b7c13a11166cf5b8c2
---

 modules/control/dbus/dbus_player.c    |  303 +++++----------------------------
 modules/control/dbus/dbus_root.c      |  201 ++++------------------
 modules/control/dbus/dbus_tracklist.c |   80 +++------
 3 files changed, 110 insertions(+), 474 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=6ae4c72da0c9b94b5f6c52b7c13a11166cf5b8c2


More information about the vlc-commits mailing list