[vlc-commits] Fix potential missing unlock (cid #1049392)

Rémi Duraffort git at videolan.org
Tue Jul 23 10:19:41 CEST 2013


vlc/vlc-2.1 | branch: master | Rémi Duraffort <ivoire at videolan.org> | Mon Jul 22 19:36:07 2013 +0200| [65217b51e83054b46cdac0c07e4382be2697b5e3] | committer: Jean-Baptiste Kempf

Fix potential missing unlock (cid #1049392)

(cherry picked from commit bcf29dd637a4eebd27436e716196bae4199d642a)
Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.1.git/?a=commit;h=65217b51e83054b46cdac0c07e4382be2697b5e3
---

 modules/video_filter/puzzle.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/modules/video_filter/puzzle.c b/modules/video_filter/puzzle.c
index 5a34d92..c23596f 100644
--- a/modules/video_filter/puzzle.c
+++ b/modules/video_filter/puzzle.c
@@ -448,7 +448,10 @@ picture_t *Filter( filter_t *p_filter, picture_t *p_pic_in ) {
             && p_sys->s_current_param.b_advanced ) {
         i_ret = puzzle_sort_layers( p_filter);
         if (i_ret != VLC_SUCCESS)
+        {
+            vlc_mutex_unlock( &p_sys->pce_lock );
             return CopyInfoAndRelease( p_pic_out, p_pic_in );
+        }
     }
 
     for (uint32_t i = 0; i < __MAX( 4, p_sys->s_allocated.i_pieces_nbr / 24 )



More information about the vlc-commits mailing list