[vlc-commits] Fix potential missing unlock (cid #1049393)

Rémi Duraffort git at videolan.org
Tue Jul 23 10:19:41 CEST 2013


vlc/vlc-2.1 | branch: master | Rémi Duraffort <ivoire at videolan.org> | Mon Jul 22 19:37:45 2013 +0200| [0131d35e4a4075fc92dc91b1d165a4e3921c069f] | committer: Jean-Baptiste Kempf

Fix potential missing unlock (cid #1049393)

(cherry picked from commit cbf0d74bfbd4b6d0df0765c9417ea2f10189f0b3)
Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.1.git/?a=commit;h=0131d35e4a4075fc92dc91b1d165a4e3921c069f
---

 modules/video_filter/puzzle.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/modules/video_filter/puzzle.c b/modules/video_filter/puzzle.c
index c23596f..3cef612 100644
--- a/modules/video_filter/puzzle.c
+++ b/modules/video_filter/puzzle.c
@@ -746,7 +746,10 @@ int puzzle_mouse( filter_t *p_filter, vlc_mouse_t *p_mouse,
             if (p_sys->i_mouse_drag_pce != NO_PCE) {
                 int i_ret = puzzle_piece_foreground( p_filter, p_sys->i_mouse_drag_pce);
                 if (i_ret != VLC_SUCCESS)
+                {
+                    vlc_mutex_unlock( &p_sys->pce_lock );
                     return i_ret;
+                }
                 p_sys->i_mouse_drag_pce = 0;
 
                 uint32_t i_group_ID = p_sys->ps_pieces[0].i_group_ID;



More information about the vlc-commits mailing list