[vlc-commits] macosx: add missing retains when exchanging views

David Fuhrmann git at videolan.org
Thu Jun 6 21:11:13 CEST 2013


vlc | branch: master | David Fuhrmann <david.fuhrmann at googlemail.com> | Thu Jun  6 21:04:18 2013 +0200| [3c2b8b3e3afa981066889a8a64abeab807a05472] | committer: David Fuhrmann

macosx: add missing retains when exchanging views

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=3c2b8b3e3afa981066889a8a64abeab807a05472
---

 modules/gui/macosx/Windows.m |    4 ++++
 1 file changed, 4 insertions(+)

diff --git a/modules/gui/macosx/Windows.m b/modules/gui/macosx/Windows.m
index a9eb6b4..2b50dad 100644
--- a/modules/gui/macosx/Windows.m
+++ b/modules/gui/macosx/Windows.m
@@ -784,9 +784,11 @@
 
             [screen setFullscreenPresentationOptions];
 
+            [o_video_view retain];
             [[o_video_view superview] replaceSubview:o_video_view with:o_temp_view];
             [o_temp_view setFrame:[o_video_view frame]];
             [o_fullscreen_window setContentView:o_video_view];
+            [o_video_view release];
 
             [o_fullscreen_window makeKeyAndOrderFront:self];
             [o_fullscreen_window orderFront:self animate:YES];
@@ -807,9 +809,11 @@
 
         /* Make sure we don't see the o_video_view disappearing of the screen during this operation */
         NSDisableScreenUpdates();
+        [o_video_view retain];
         [[o_video_view superview] replaceSubview:o_video_view with:o_temp_view];
         [o_temp_view setFrame:[o_video_view frame]];
         [o_fullscreen_window setContentView:o_video_view];
+        [o_video_view release];
         [o_fullscreen_window makeKeyAndOrderFront:self];
         NSEnableScreenUpdates();
     }



More information about the vlc-commits mailing list