[vlc-commits] macosx: destroy lua dialogs correctly on close (close #8567)

[Felix Paul Kühne]

vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Sat May 11 16:26:58 2013 +0200| [b2e472265666897d58b7aca712e6fa9c0ac4f862] | committer: Felix Paul Kühne

macosx: destroy lua dialogs correctly on close (close #8567)

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b2e472265666897d58b7aca712e6fa9c0ac4f862
---

 modules/gui/macosx/ExtensionsDialogProvider.m |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/modules/gui/macosx/ExtensionsDialogProvider.m b/modules/gui/macosx/ExtensionsDialogProvider.m
index 03f9cff..4f928b4 100644
--- a/modules/gui/macosx/ExtensionsDialogProvider.m
+++ b/modules/gui/macosx/ExtensionsDialogProvider.m
@@ -497,10 +497,14 @@ static ExtensionsDialogProvider *_o_sharedInstance = nil;
     assert(p_dialog);
 
     VLCDialogWindow *dialogWindow = (VLCDialogWindow*) p_dialog->p_sys_intf;
-    if (!dialogWindow)
+    if (!dialogWindow) {
+        msg_Warn(VLCIntf, "dialog window not found");
         return VLC_EGENERIC;
+    }
 
-    [VLCDialogWindow release];
+    [dialogWindow setDelegate:nil];
+    [dialogWindow close];
+    dialogWindow = nil;
 
     p_dialog->p_sys_intf = NULL;
     vlc_cond_signal(&p_dialog->cond);