[vlc-commits] nsis: request admin execution level

Ludovic Fauvet git at videolan.org
Fri Nov 29 13:28:44 CET 2013


vlc | branch: master | Ludovic Fauvet <etix at videolan.org> | Fri Nov 29 12:56:43 2013 +0100| [952646bbe4870330a4128f3cd5cc7f8ee0772516] | committer: Ludovic Fauvet

nsis: request admin execution level

The current state of our NSIS installer doesn't support per-user
installation and needs a major rework to do so, therefore the user
is required to have admin privileges to install VLC.

Still, RequestExecutionLevel was set to 'user' to be able to drop
privileges when launching vlc.exe at the end of the installation but
this was improved since (90496f23c2481bbaea21a586bc22631850751221) and
confirmed by the accesschk tool.

However requesting user execution level makes the unpacking occurs
twice: once with the user level and once after elevation.

Requesting admin permissions fixes the unpacking issue while still being
safe when launching VLC after the installation on XP and above.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=952646bbe4870330a4128f3cd5cc7f8ee0772516
---

 extras/package/win32/NSIS/vlc.win32.nsi.in |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/extras/package/win32/NSIS/vlc.win32.nsi.in b/extras/package/win32/NSIS/vlc.win32.nsi.in
index 33f162e..8278413 100644
--- a/extras/package/win32/NSIS/vlc.win32.nsi.in
+++ b/extras/package/win32/NSIS/vlc.win32.nsi.in
@@ -56,7 +56,7 @@ InstType $Name_InstTypeRecommended
 InstType $Name_InstTypeMinimum
 InstType $Name_InstTypeFull
 
-RequestExecutionLevel user
+RequestExecutionLevel admin
 !addincludedir NSIS
 !addplugindir NSIS
 !include UAC.nsh



More information about the vlc-commits mailing list