[vlc-commits] Core: Disable vout recycling for the visualization

Adrien Maglo git at videolan.org
Sat Sep 7 19:36:19 CEST 2013


vlc/vlc-2.1 | branch: master | Adrien Maglo <magsoft at videolan.org> | Sun Sep  1 13:48:49 2013 +0200| [7107684037099c3bfec419f7adc108a7afcea0dc] | committer: Jean-Baptiste Kempf

Core: Disable vout recycling for the visualization

This avoids the vout opened for by the "visual" module to stay opened after having started an OpenGL based visualization.

This fixes #9270 for 2.1.0 release, because of lack of time...

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.1.git/?a=commit;h=7107684037099c3bfec419f7adc108a7afcea0dc
---

 src/audio_output/filters.c |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/audio_output/filters.c b/src/audio_output/filters.c
index 41b23b4..59346c1 100644
--- a/src/audio_output/filters.c
+++ b/src/audio_output/filters.c
@@ -337,7 +337,9 @@ vout_thread_t *aout_filter_RequestVout (filter_t *filter, vout_thread_t *vout,
      * to aout_request_vout_t inside filter_t (i.e. a level of indirection). */
     const aout_request_vout_t *req = (void *)filter->p_owner;
     char *visual = var_InheritString (filter->p_parent, "audio-visual");
-    bool recycle = (visual != NULL) && strcasecmp(visual, "none");
+    /* NOTE: Disable recycling to always close the filter vout because OpenGL
+     * visualizations do not use this function to ask for a context. */
+    bool recycle = false;
     free (visual);
 
     return req->pf_request_vout (req->p_private, vout, fmt, recycle);



More information about the vlc-commits mailing list