[vlc-commits] dbus: memory leak

Rémi Denis-Courmont git at videolan.org
Wed Apr 23 22:37:40 CEST 2014


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Apr 23 23:37:35 2014 +0300| [37f6e513110c8befb68b3260a10bfe53a3de135d] | committer: Rémi Denis-Courmont

dbus: memory leak

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=37f6e513110c8befb68b3260a10bfe53a3de135d
---

 modules/control/dbus/dbus_player.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/control/dbus/dbus_player.c b/modules/control/dbus/dbus_player.c
index 7fd8b77..0906934 100644
--- a/modules/control/dbus/dbus_player.c
+++ b/modules/control/dbus/dbus_player.c
@@ -872,6 +872,8 @@ PropertiesChangedSignal( intf_thread_t    *p_intf,
         free( ppsz_properties[i] );
     }
 
+    free( ppsz_properties );
+
     if( !dbus_message_iter_close_container( &args, &changed_properties ) )
         return DBUS_HANDLER_RESULT_NEED_MEMORY;
 
@@ -882,8 +884,6 @@ PropertiesChangedSignal( intf_thread_t    *p_intf,
     if( !dbus_message_iter_close_container( &args, &invalidated_properties ) )
         return DBUS_HANDLER_RESULT_NEED_MEMORY;
 
-    free( ppsz_properties );
-
     SIGNAL_SEND;
 }
 



More information about the vlc-commits mailing list