[vlc-commits] macosx: resume playback: fix memleak

David Fuhrmann git at videolan.org
Tue Dec 30 16:12:01 CET 2014


vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Sun Dec 28 17:22:14 2014 +0100| [598ae833b9fcc8080b6292efb1e48a5cdc93ef72] | committer: David Fuhrmann

macosx: resume playback: fix memleak

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=598ae833b9fcc8080b6292efb1e48a5cdc93ef72
---

 modules/gui/macosx/playlist.m |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/modules/gui/macosx/playlist.m b/modules/gui/macosx/playlist.m
index 8e61e70..fb7b763 100644
--- a/modules/gui/macosx/playlist.m
+++ b/modules/gui/macosx/playlist.m
@@ -1064,10 +1064,14 @@
     NSInteger returnValue = NSAlertErrorReturn;
     if (settingValue == 0) { // ask
 
+        char *psz_title_name = input_item_GetTitleFbName(p_item);
+        NSString *o_title = toNSStr(psz_title_name);
+        free(psz_title_name);
+
         currentResumeTimeout = 6;
         NSString *o_restartButtonLabel = _NS("Restart playback");
         o_restartButtonLabel = [o_restartButtonLabel stringByAppendingFormat:@" (%d)", currentResumeTimeout];
-        NSAlert *theAlert = [NSAlert alertWithMessageText:_NS("Continue playback?") defaultButton:_NS("Continue") alternateButton:o_restartButtonLabel otherButton:_NS("Always continue") informativeTextWithFormat:_NS("Playback of \"%@\" will continue at %@"), [NSString stringWithUTF8String:input_item_GetTitleFbName(p_item)], [[VLCStringUtility sharedInstance] stringForTime:lastPosition.intValue]];
+        NSAlert *theAlert = [NSAlert alertWithMessageText:_NS("Continue playback?") defaultButton:_NS("Continue") alternateButton:o_restartButtonLabel otherButton:_NS("Always continue") informativeTextWithFormat:_NS("Playback of \"%@\" will continue at %@"), o_title, [[VLCStringUtility sharedInstance] stringForTime:lastPosition.intValue]];
 
         NSTimer *timer = [NSTimer timerWithTimeInterval:1
                                                  target:self



More information about the vlc-commits mailing list