[vlc-commits] npmac: remove remnants

Felix Paul Kühne git at videolan.org
Mon Feb 17 20:19:05 CET 2014


npapi-vlc | branch: master | Felix Paul Kühne <fkuehne at videolan.org> | Mon Feb 17 20:18:48 2014 +0100| [9db46e041975ccec9d8d1045f75aa6f54adbf6d2] | committer: Felix Paul Kühne

npmac: remove remnants

> http://git.videolan.org/gitweb.cgi/npapi-vlc.git/?a=commit;h=9db46e041975ccec9d8d1045f75aa6f54adbf6d2
---

 npapi/support/npmac.cpp |   25 +++++--------------------
 1 file changed, 5 insertions(+), 20 deletions(-)

diff --git a/npapi/support/npmac.cpp b/npapi/support/npmac.cpp
index 4e92222..c3525cf 100644
--- a/npapi/support/npmac.cpp
+++ b/npapi/support/npmac.cpp
@@ -438,26 +438,11 @@ NPError    Private_New(NPMIMEType pluginType, NPP instance, uint16_t mode, int16
             return NPERR_INCOMPATIBLE_VERSION_ERROR;
         }
 
-        /* FIXME by implementing CoreAnimation invalidation
-        NPBool supportsInvalidatingCoreAnimation = FALSE;
-        err = NPN_GetValue(instance, NPNVsupportsInvalidatingCoreAnimationBool, &supportsInvalidatingCoreAnimation);
-        if (err != NPERR_NO_ERROR || !supportsInvalidatingCoreAnimation)
-            fprintf(stderr, "New: browser doesn't support the Invalidating CoreAnimation drawing model\n");
-
-        if (supportsInvalidatingCoreAnimation) {
-            err = NPN_SetValue(instance, NPPVpluginDrawingModel, (void*)NPDrawingModelInvalidatingCoreAnimation);
-            if (err != NPERR_NO_ERROR) {
-                fprintf(stderr, "Error in New: couldn't activate Invalidating CoreAnimation drawing model\n");
-                return NPERR_INCOMPATIBLE_VERSION_ERROR;
-            }
-        } else {*/
-            fprintf(stderr, "New: falling back to non-invalidating CoreAnimation drawing, since invalidation is not supported\n");
-            err = NPN_SetValue(instance, NPPVpluginDrawingModel, (void*)NPDrawingModelCoreAnimation);
-            if (err != NPERR_NO_ERROR) {
-                fprintf(stderr, "Error in New: couldn't activate CoreAnimation drawing model\n");
-                return NPERR_INCOMPATIBLE_VERSION_ERROR;
-            }
-        //}
+        err = NPN_SetValue(instance, NPPVpluginDrawingModel, (void*)NPDrawingModelCoreAnimation);
+        if (err != NPERR_NO_ERROR) {
+            fprintf(stderr, "Error in New: couldn't activate CoreAnimation drawing model\n");
+            return NPERR_INCOMPATIBLE_VERSION_ERROR;
+        }
     }
 
     NPBool supportsCocoaEvents = FALSE;



More information about the vlc-commits mailing list