[vlc-commits] DirectSound: avoid double call to release function

[Felix Abecassis]

vlc | branch: master | Felix Abecassis <felix.abecassis at gmail.com> | Fri Feb 28 15:55:29 2014 +0100| [9b72dc3fa6776558d9fca0e506ec39b40ba39c7a] | committer: Rémi Denis-Courmont

DirectSound: avoid double call to release function

If Start() failed, IDirectSound_Release() was called twice.

Signed-off-by: Rémi Denis-Courmont <remi at remlab.net> with changes

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9b72dc3fa6776558d9fca0e506ec39b40ba39c7a
---

 modules/audio_output/directsound.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/modules/audio_output/directsound.c b/modules/audio_output/directsound.c
index b2a9ca6..cb986fe 100644
--- a/modules/audio_output/directsound.c
+++ b/modules/audio_output/directsound.c
@@ -772,10 +772,7 @@ static HRESULT StreamStart( aout_stream_t *s,
 
     hr = Start( VLC_OBJECT(s), sys, fmt );
     if( FAILED(hr) )
-    {
-        IDirectSound_Release( sys->p_dsobject );
         goto error;
-    }
 
     s->sys = sys;
     s->time_get = StreamTimeGet;