[vlc-commits] mux: ogg: uninitialized value

Francois Cartegnie git at videolan.org
Thu Jan 16 19:35:41 CET 2014


vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Thu Jan 16 01:38:39 2014 +0100| [67b7e7466cb828f3b7e68d27c520cb60da693824] | committer: Francois Cartegnie

mux: ogg: uninitialized value

1st header write can contain random values but that
triggers false positive on valgrind.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=67b7e7466cb828f3b7e68d27c520cb60da693824
---

 modules/mux/ogg.c |    2 ++
 1 file changed, 2 insertions(+)

diff --git a/modules/mux/ogg.c b/modules/mux/ogg.c
index 0734897..b179e20 100644
--- a/modules/mux/ogg.c
+++ b/modules/mux/ogg.c
@@ -248,6 +248,8 @@ static int Open( vlc_object_t *p_this )
             var_InheritInteger( p_this, SOUT_CFG_PREFIX "indexintvl" );
     p_sys->skeleton.i_index_ratio =
             var_InheritFloat( p_this, SOUT_CFG_PREFIX "indexratio" );
+    p_sys->i_data_start = 0;
+    p_sys->i_segment_start = 0;
     p_mux->p_sys        = p_sys;
     p_mux->pf_control   = Control;
     p_mux->pf_addstream = AddStream;



More information about the vlc-commits mailing list