[vlc-commits] Revert "macosx: enable native fullscreen by default on mavericks"

David Fuhrmann git at videolan.org
Sun Jun 1 11:29:35 CEST 2014


vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Thu May 29 17:13:21 2014 +0200| [83eb67671f0a08c0e11f5816b686adbe55fbc4be] | committer: David Fuhrmann

Revert "macosx: enable native fullscreen by default on mavericks"

They are several complaints for nonworking functionality with this
mode, because not every option combination is supported yet.

Additionally, the initial reason for this commit, namely grey
bars in fullscreen, is fixed by a workaround for 2.2.

This reverts commit 72b60566a25ca24cb4cf54d394a8275bee5cc9e8.

Conflicts:
	modules/gui/macosx/macosx.m

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=83eb67671f0a08c0e11f5816b686adbe55fbc4be
---

 modules/gui/macosx/macosx.m |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/modules/gui/macosx/macosx.m b/modules/gui/macosx/macosx.m
index b0f99cc..73f308f 100644
--- a/modules/gui/macosx/macosx.m
+++ b/modules/gui/macosx/macosx.m
@@ -35,8 +35,6 @@
 #include <vlc_plugin.h>
 #include <vlc_vout_window.h>
 
-#include "CompatibilityFixes.h"
-
 /*****************************************************************************
  * External prototypes
  *****************************************************************************/
@@ -151,11 +149,9 @@ vlc_module_begin()
     set_subcategory(SUBCAT_INTERFACE_MAIN)
     cannot_unload_broken_library()
 
-    BOOL b_have_mavericks = OSX_MAVERICKS;
-
     set_section(N_("Appearance"), 0)
         add_bool("macosx-interfacestyle", false, INTERFACE_STYLE_TEXT, INTERFACE_STYLE_LONGTEXT, false)
-        add_bool("macosx-nativefullscreenmode", b_have_mavericks, NATIVE_FULLSCREEN_MODE_ON_LION_TEXT, NATIVE_FULLSCREEN_MODE_ON_LION_LONGTEXT, false)
+        add_bool("macosx-nativefullscreenmode", false, NATIVE_FULLSCREEN_MODE_ON_LION_TEXT, NATIVE_FULLSCREEN_MODE_ON_LION_LONGTEXT, false)
         add_bool("macosx-icon-change", true, ICONCHANGE_TEXT, ICONCHANGE_LONGTEXT, true)
         add_bool("macosx-show-playback-buttons", false, JUMPBUTTONS_TEXT, JUMPBUTTONS_LONGTEXT, false)
         add_bool("macosx-show-playmode-buttons", false, PLAYMODEBUTTONS_TEXT, PLAYMODEBUTTONS_LONGTEXT, false)



More information about the vlc-commits mailing list