[vlc-commits] video output: fix offsets and visible dimensions of filtered video

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Mar 13 21:03:57 2014 +0200| [5290dabebe81e97fafc7f2f9a63f22bcb7884d0a] | committer: Rémi Denis-Courmont

video output: fix offsets and visible dimensions of filtered video

This parameter copy was working around broken format-changing video
filters, but it broke filters updating the format correctly
(deinterlace, transform and croppadd).

Refs #10745. Note that transform is still not working correctly: the
aspect ratio is broken for transpositation and quarter rotations. This
latent bug should vanish with the video orientation support later.
Otherwise the proper fix is to allow the filters chain to change the
format.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=5290dabebe81e97fafc7f2f9a63f22bcb7884d0a
---

 src/video_output/video_output.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/video_output/video_output.c b/src/video_output/video_output.c
index 8088d95..bd505f3 100644
--- a/src/video_output/video_output.c
+++ b/src/video_output/video_output.c
@@ -795,7 +795,7 @@ static void ThreadChangeFilters(vout_thread_t *vout,
         fmt_current = *filter_chain_GetFmtOut(chain);
         vlc_array_clear(array);
     }
-    VideoFormatCopyCropAr(&fmt_target.video, &fmt_current.video);
+
     if (!es_format_IsSimilar(&fmt_current, &fmt_target)) {
         msg_Dbg(vout, "Adding a filter to compensate for format changes");
         if (!filter_chain_AppendFilter(vout->p->filter.chain_interactive, NULL, NULL,