[vlc-commits] audiobargraph: avoid heap allocation

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Mar 20 22:34:16 2014 +0200| [afc248574db5bec45225c7484d10619b2a76ab6f] | committer: Rémi Denis-Courmont

audiobargraph: avoid heap allocation

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=afc248574db5bec45225c7484d10619b2a76ab6f
---

 modules/audio_filter/audiobargraph_a.c |    8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/modules/audio_filter/audiobargraph_a.c b/modules/audio_filter/audiobargraph_a.c
index 53223d3..5d4caec 100644
--- a/modules/audio_filter/audiobargraph_a.c
+++ b/modules/audio_filter/audiobargraph_a.c
@@ -169,7 +169,7 @@ static block_t *DoWork( filter_t *p_filter, block_t *p_in_buf )
     filter_sys_t *p_sys = p_filter->p_sys;
     int i, j;
     float *p_sample = (float *)p_in_buf->p_buffer;
-    float *i_value = NULL;
+    float i_value[AOUT_CHAN_MAX];
     float ch;
     float max = 0.0;
     //char *message = (char*)malloc(255*sizeof(char));
@@ -183,10 +183,8 @@ static block_t *DoWork( filter_t *p_filter, block_t *p_in_buf )
     nbChannels = aout_FormatNbChannels( &p_filter->fmt_in.audio );
     p_sys->nbChannels = nbChannels;
 
-    i_value = (float*)malloc(nbChannels * sizeof(float));
-
     for (i=0; i<nbChannels; i++) {
-        i_value[i] = 0;
+        i_value[i] = 0.;
     }
 
     /* 1 - Compute the peack values */
@@ -281,8 +279,6 @@ static block_t *DoWork( filter_t *p_filter, block_t *p_in_buf )
         }
     }
 
-    free(i_value);
-
     if (p_sys->counter > p_sys->bargraph_repetition*100) {
         if (p_sys->connection_reset) {
             net_Close(p_sys->TCPconnection);