[vlc-commits] mosaic: use after free

[Rémi Denis-Courmont]

vlc/vlc-2.2 | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Nov  5 23:23:35 2014 +0200| [acacaebfde04eda320d9a829bc3489c0a6ada27d] | committer: Rémi Denis-Courmont

mosaic: use after free

(cherry picked from commit d0b6ecb24e52d943bbb2f0debdc4237b4b112aee)

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.2.git/?a=commit;h=acacaebfde04eda320d9a829bc3489c0a6ada27d
---

 modules/video_filter/mosaic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/video_filter/mosaic.c b/modules/video_filter/mosaic.c
index a9aef44..14703a6 100644
--- a/modules/video_filter/mosaic.c
+++ b/modules/video_filter/mosaic.c
@@ -651,7 +651,7 @@ static subpicture_t *Filter( filter_t *p_filter, mtime_t date )
             p_filter->pf_sub_buffer_del( p_filter, p_spu );
             vlc_global_unlock( VLC_MOSAIC_MUTEX );
             vlc_mutex_unlock( &p_sys->lock );
-            return p_spu;
+            return NULL;
         }
 
         if( p_es->i_x >= 0 && p_es->i_y >= 0 )