[vlc-commits] http_auth: remove useless predicate

Rémi Denis-Courmont git at videolan.org
Fri Nov 14 18:34:08 CET 2014


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Fri Nov 14 19:33:24 2014 +0200| [e312e2103b13da5180ba038109912302b837e27a] | committer: Rémi Denis-Courmont

http_auth: remove useless predicate

Ternary: a ? b : b

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e312e2103b13da5180ba038109912302b837e27a
---

 src/misc/http_auth.c |    7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/misc/http_auth.c b/src/misc/http_auth.c
index 0e224da..7d6d245 100644
--- a/src/misc/http_auth.c
+++ b/src/misc/http_auth.c
@@ -436,7 +436,7 @@ char *http_auth_FormatAuthorizationHeader(
             "%s%s%s" /* cnonce */
             "%s%s%s" /* opaque */
             "%s%s%s" /* message qop */
-            "%s%08x%s", /* nonce count */
+            "%s=\"%08x\"", /* nonce count */
             /* Mandatory parameters */
             psz_username,
             p_auth->psz_realm,
@@ -457,9 +457,8 @@ char *http_auth_FormatAuthorizationHeader(
             p_auth->psz_qop ? p_auth->psz_qop : "",
             p_auth->psz_qop ? "\", " : "",
             /* "uglyhack" will be parsed as an unhandled extension */
-            p_auth->i_nonce ? "nc=\"" : "uglyhack=\"",
-            p_auth->i_nonce,
-            p_auth->i_nonce ? "\"" : "\""
+            p_auth->i_nonce ? "nc" : "uglyhack",
+            p_auth->i_nonce
         );
         if ( i_rc < 0 )
             goto error;



More information about the vlc-commits mailing list