[vlc-commits] XCB/XVideo: do not fallback to YUYV output for RGB inputs

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sun Oct  5 22:41:51 2014 +0300| [2c1940d7d3d103b19ce329697136bc21ab014754] | committer: Rémi Denis-Courmont

XCB/XVideo: do not fallback to YUYV output for RGB inputs

If the XVideo driver does not provide any RGB image format, then we
are definitely better off with GLX than XVideo. Consider:
 - GLX supports proper subpicture blending - not XVideo,
 - GLX does not need chroma conversion - XVideo does in this case.

This change makes no difference if the XVideo driver supports RGB.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2c1940d7d3d103b19ce329697136bc21ab014754
---

 modules/video_output/xcb/xvideo.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/modules/video_output/xcb/xvideo.c b/modules/video_output/xcb/xvideo.c
index c7fc246..e237c01 100644
--- a/modules/video_output/xcb/xvideo.c
+++ b/modules/video_output/xcb/xvideo.c
@@ -256,7 +256,7 @@ FindFormat (vlc_object_t *obj, xcb_connection_t *conn, video_format_t *fmt,
             const xcb_xv_adaptor_info_t *a, uint32_t *idp)
 {
     /* Order chromas by preference */
-    vlc_fourcc_t tab[7];
+    vlc_fourcc_t tab[6];
     const vlc_fourcc_t *chromav = tab;
 
     vlc_fourcc_t chroma = var_InheritInteger (obj, "xvideo-format-id");
@@ -276,8 +276,7 @@ FindFormat (vlc_object_t *obj, xcb_connection_t *conn, video_format_t *fmt,
         tab[2] = VLC_CODEC_RGB24;
         tab[3] = VLC_CODEC_RGB16;
         tab[4] = VLC_CODEC_RGB15;
-        tab[5] = VLC_CODEC_YUYV;
-        tab[6] = 0;
+        tab[5] = 0;
     }
 
     /* Get available image formats */