[vlc-commits] demux: libmp4: fix heap overflow in stdp debug code (fix #12358)

Francois Cartegnie git at videolan.org
Thu Oct 9 13:41:33 CEST 2014


vlc/vlc-2.2 | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Wed Oct  8 15:17:55 2014 +0200| [5249240cf82e58e6ec1177706a2a9c22ad1d3155] | committer: Jean-Baptiste Kempf

demux: libmp4: fix heap overflow in stdp debug code (fix #12358)

(cherry picked from commit 2caa3ce4d4a50da0796d0e2bb7feebb53aed8f8f)
Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.2.git/?a=commit;h=5249240cf82e58e6ec1177706a2a9c22ad1d3155
---

 modules/demux/mp4/libmp4.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/modules/demux/mp4/libmp4.c b/modules/demux/mp4/libmp4.c
index 6609369..d776254 100644
--- a/modules/demux/mp4/libmp4.c
+++ b/modules/demux/mp4/libmp4.c
@@ -3042,7 +3042,8 @@ static int MP4_ReadBox_sdtp( stream_t *p_stream, MP4_Box_t *p_box )
 
 #ifdef MP4_VERBOSE
     msg_Dbg( p_stream, "i_sample_count is %"PRIu32"", i_sample_count );
-    msg_Dbg( p_stream,
+    if ( i_sample_count > 3 )
+        msg_Dbg( p_stream,
              "read box: \"sdtp\" head: %"PRIx8" %"PRIx8" %"PRIx8" %"PRIx8"",
                  p_sdtp->p_sample_table[0],
                  p_sdtp->p_sample_table[1],



More information about the vlc-commits mailing list