[vlc-commits] codec/zvbi: Only reset subpicture in text mode

Julian Scheel git at videolan.org
Fri Oct 10 12:17:44 CEST 2014


vlc | branch: master | Julian Scheel <julian at jusst.de> | Fri Oct 10 11:21:07 2014 +0200| [47012982d20cf537fc710edd14c9c9c4183d0a19] | committer: Jean-Baptiste Kempf

codec/zvbi: Only reset subpicture in text mode

The subpicture reset, as stated in the comment, is only required when
rendering text-subtitles. In fact it causes an invalid image to be generated
and possibly output in non-text mode. Hence disable the picture recreation for
non-text mode.

Signed-off-by: Julian Scheel <julian at jusst.de>
Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=47012982d20cf537fc710edd14c9c9c4183d0a19
---

 modules/codec/zvbi.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/codec/zvbi.c b/modules/codec/zvbi.c
index a30d0bd..fa5b7c3 100644
--- a/modules/codec/zvbi.c
+++ b/modules/codec/zvbi.c
@@ -372,7 +372,7 @@ static subpicture_t *Decode( decoder_t *p_dec, block_t **pp_block )
 
     if( !b_cached )
     {
-        if( p_sys->i_last_page != i_wanted_page )
+        if( p_sys->b_text && p_sys->i_last_page != i_wanted_page )
         {
             /* We need to reset the subtitle */
             p_spu = Subpicture( p_dec, &fmt, true,



More information about the vlc-commits mailing list