[vlc-commits] mmal/vout: Optimise struct packing

Julian Scheel git at videolan.org
Wed Oct 15 10:28:58 CEST 2014


vlc | branch: master | Julian Scheel <julian at jusst.de> | Wed Oct 15 10:05:29 2014 +0200| [a5930aa11b13ac2791d7c8c1b7d67a3e6e8dfde6] | committer: Jean-Baptiste Kempf

mmal/vout: Optimise struct packing

Sort vout_sys_t struct members by size to optimize packing.

Signed-off-by: Julian Scheel <julian at jusst.de>
Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=a5930aa11b13ac2791d7c8c1b7d67a3e6e8dfde6
---

 modules/hw/mmal/vout.c |   15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/modules/hw/mmal/vout.c b/modules/hw/mmal/vout.c
index 2c4d1a0..6c4de59 100644
--- a/modules/hw/mmal/vout.c
+++ b/modules/hw/mmal/vout.c
@@ -85,6 +85,11 @@ struct dmx_region_t {
 };
 
 struct vout_display_sys_t {
+    vlc_cond_t buffer_cond;
+    vlc_mutex_t buffer_mutex;
+    vlc_mutex_t manage_mutex;
+
+    plane_t planes[3];
     picture_t **pictures;
     picture_pool_t *picture_pool;
 
@@ -92,12 +97,8 @@ struct vout_display_sys_t {
     MMAL_PORT_T *input;
     MMAL_POOL_T *pool;
     struct dmx_region_t *dmx_region;
-    plane_t planes[3];
     int i_planes;
 
-    vlc_mutex_t buffer_mutex;
-    vlc_mutex_t manage_mutex;
-    vlc_cond_t buffer_cond;
     uint32_t buffer_size;
     int buffers_in_transit;
     unsigned num_buffers;
@@ -107,13 +108,13 @@ struct vout_display_sys_t {
     DISPMANX_RESOURCE_HANDLE_T bkg_resource;
     unsigned display_width;
     unsigned display_height;
-    bool need_configure_display;
 
-    bool adjust_refresh_rate;
     int next_phase_check;
     int phase_offset;
-
     int layer;
+
+    bool need_configure_display;
+    bool adjust_refresh_rate;
     bool opaque;
 };
 



More information about the vlc-commits mailing list