[vlc-commits] qt4: Replace redundant virtual with Q_DECL_OVERRIDE

[Uwe L. Korn]

vlc | branch: master | Uwe L. Korn <uwelk at xhochy.com> | Mon Aug 18 21:05:06 2014 +0000| [212bf2e8a58645d238535c41aedd96ccb6afa210] | committer: Tristan Matthews

qt4: Replace redundant virtual with Q_DECL_OVERRIDE

Declaring a virtual function in a subclass as virtual may be a good
documentation that we are overriding a method from the superclass but
has no effect during compilation. With C++11, we can use the override
keyword for this (which will even trigger a compiler error if we try to
override a non-virtual function).

To stay backwards-compatible, we use Qt5's Q_DECL_OVERRIDE macro to
support C++ <11.

Signed-off-by: Tristan Matthews <le.businessman at gmail.com>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=212bf2e8a58645d238535c41aedd96ccb6afa210
---

 modules/gui/qt4/adapters/variables.hpp             |   12 ++-
 modules/gui/qt4/components/controller.hpp          |   16 ++--
 modules/gui/qt4/components/controller_widget.hpp   |    2 +-
 modules/gui/qt4/components/epg/EPGChannels.hpp     |    4 +-
 modules/gui/qt4/components/epg/EPGItem.hpp         |   10 +-
 modules/gui/qt4/components/epg/EPGRuler.hpp        |    4 +-
 modules/gui/qt4/components/extended_panels.hpp     |   13 +--
 modules/gui/qt4/components/info_panels.hpp         |    4 +-
 modules/gui/qt4/components/interface_widgets.hpp   |   26 +++---
 modules/gui/qt4/components/open_panels.hpp         |   30 +++---
 modules/gui/qt4/components/playlist/playlist.hpp   |   18 ++--
 .../gui/qt4/components/playlist/playlist_model.hpp |   50 +++++-----
 modules/gui/qt4/components/playlist/selector.hpp   |   12 +--
 .../gui/qt4/components/playlist/standardpanel.hpp  |    2 +-
 modules/gui/qt4/components/playlist/views.hpp      |   58 ++++++------
 modules/gui/qt4/components/playlist/vlc_model.hpp  |   14 +--
 modules/gui/qt4/components/preferences_widgets.hpp |   96 ++++++++++----------
 .../gui/qt4/components/sout/profile_selector.hpp   |    2 +-
 modules/gui/qt4/components/sout/sout_widgets.hpp   |   14 +--
 modules/gui/qt4/dialogs/convert.hpp                |    4 +-
 modules/gui/qt4/dialogs/extensions.hpp             |    4 +-
 modules/gui/qt4/dialogs/gototime.hpp               |    4 +-
 modules/gui/qt4/dialogs/help.hpp                   |    6 +-
 modules/gui/qt4/dialogs/mediainfo.hpp              |    2 +-
 modules/gui/qt4/dialogs/openurl.hpp                |    2 +-
 modules/gui/qt4/dialogs/playlist.hpp               |    2 +-
 modules/gui/qt4/dialogs/plugins.hpp                |   58 ++++++------
 modules/gui/qt4/dialogs/toolbar.hpp                |   20 ++--
 modules/gui/qt4/dialogs/vlm.hpp                    |    2 +-
 modules/gui/qt4/main_interface.hpp                 |   18 ++--
 modules/gui/qt4/styles/seekstyle.hpp               |    6 +-
 modules/gui/qt4/util/animators.hpp                 |   10 +-
 modules/gui/qt4/util/customwidgets.hpp             |   13 +--
 modules/gui/qt4/util/input_slider.hpp              |   30 +++---
 modules/gui/qt4/util/pictureflow.hpp               |    4 +-
 modules/gui/qt4/util/qvlcframe.hpp                 |    4 +-
 modules/gui/qt4/util/searchlineedit.hpp            |   16 ++--
 modules/gui/qt4/util/timetooltip.hpp               |    4 +-
 modules/gui/qt4/util/validators.hpp                |    6 +-
 39 files changed, 310 insertions(+), 292 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=212bf2e8a58645d238535c41aedd96ccb6afa210