[vlc-commits] playlist: fetcher: fix memory leaks

Hannes Domani git at videolan.org
Wed Sep 10 06:48:02 CEST 2014


vlc/vlc-2.2 | branch: master | Hannes Domani <ssbssa at yahoo.de> | Wed Sep  3 19:52:28 2014 +0200| [4335aecfa64c12d7ec6d8414586caa948edd359f] | committer: Tristan Matthews

playlist: fetcher: fix memory leaks

Signed-off-by: Tristan Matthews <le.businessman at gmail.com>
(cherry picked from commit a868b9e580a2ec98ec4a13ba5a2cf463821af337)

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.2.git/?a=commit;h=4335aecfa64c12d7ec6d8414586caa948edd359f
---

 src/playlist/fetcher.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/playlist/fetcher.c b/src/playlist/fetcher.c
index eb86994..41e0c32 100644
--- a/src/playlist/fetcher.c
+++ b/src/playlist/fetcher.c
@@ -227,15 +227,15 @@ static int FindArt( playlist_fetcher_t *p_fetcher, input_item_t *p_item )
                 msg_Dbg( p_fetcher->object,
                          " will search at higher scope, if possible" );
                 p_album = &p_fetcher->albums.p_elems[fe_idx];
+
+                psz_artist = psz_album = NULL;
                 break;
             }
         FOREACH_END();
     }
-    else
-    {
-        free( psz_artist );
-        free( psz_album );
-    }
+
+    free( psz_artist );
+    free( psz_album );
 
     if ( playlist_FindArtInCacheUsingItemUID( p_item ) != VLC_SUCCESS )
         playlist_FindArtInCache( p_item );



More information about the vlc-commits mailing list