[vlc-commits] mediacodec/omxil: blacklist samsung VP8 decoder

[Thomas Guillem]

vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Fri Apr  3 12:43:43 2015 +0200| [06e37373c2ff6daaa069f04c94cbef880c6aad6f] | committer: Jean-Baptiste Kempf

mediacodec/omxil: blacklist samsung VP8 decoder

Fixes #14227

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=06e37373c2ff6daaa069f04c94cbef880c6aad6f
---

 modules/codec/omxil/android_mediacodec.c |    2 ++
 modules/codec/omxil/omxil.c              |    3 +++
 2 files changed, 5 insertions(+)

diff --git a/modules/codec/omxil/android_mediacodec.c b/modules/codec/omxil/android_mediacodec.c
index cacfe1e..aa90cc4 100644
--- a/modules/codec/omxil/android_mediacodec.c
+++ b/modules/codec/omxil/android_mediacodec.c
@@ -397,6 +397,8 @@ static bool codec_is_blacklisted( const char *p_name, unsigned int i_name_len )
         "OMX.google.",
         /* crashes mediaserver */
         "OMX.MTK.VIDEO.DECODER.MPEG4",
+        /* Not working or crashing (Samsung) */
+        "OMX.SEC.vp8.dec",
         NULL,
      };
 
diff --git a/modules/codec/omxil/omxil.c b/modules/codec/omxil/omxil.c
index 9211f76..16eb50e 100644
--- a/modules/codec/omxil/omxil.c
+++ b/modules/codec/omxil/omxil.c
@@ -1141,6 +1141,9 @@ static int OpenGeneric( vlc_object_t *p_this, bool b_encode )
          * it until we can make it work properly. */
         if (!strcmp(p_sys->ppsz_components[i], "OMX.Nvidia.vc1.decode"))
             continue;
+        /* This codec doesn't work or crashes */
+        if (!strcmp(p_sys->ppsz_components[i], "OMX.SEC.vp8.dec"))
+            continue;
 #endif
         omx_error = InitialiseComponent(p_dec, p_sys->ppsz_components[i],
                                         &p_sys->omx_handle);