[vlc-commits] macosx: Modernize and fix shared dialog panels

David Fuhrmann git at videolan.org
Sun Aug 9 20:00:26 CEST 2015


vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Sun Aug  9 19:53:49 2015 +0200| [4da13fbc669110b24a4e3b541c91dd97304d6eac] | committer: David Fuhrmann

macosx: Modernize and fix shared dialog panels

Splits PopupPanel and TextfieldPanel into two xib files and
creates NSWindowController subclasses for each panel.

Each user of the panel gets its own window controller instance.
This is needed as the same kind of window can be shown multiple
times simultaneously (e.g. both in video and audio effects).

This also did not work with the previous implementation of the
2.2 branch and fixes broken behaviour.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=4da13fbc669110b24a4e3b541c91dd97304d6eac
---

 Makefile.am                                        |    3 +-
 .../{SharedDialogs.xib => PopupPanel.xib}          |  539 +++-------------
 .../Resources/English.lproj/TextfieldPanel.xib     |  659 ++++++++++++++++++++
 .../package/macosx/vlc.xcodeproj/project.pbxproj   |   46 +-
 modules/gui/macosx/AudioEffects.h                  |    6 +
 modules/gui/macosx/AudioEffects.m                  |   39 +-
 modules/gui/macosx/ConvertAndSave.h                |   11 +-
 modules/gui/macosx/ConvertAndSave.m                |   43 +-
 modules/gui/macosx/SharedDialogs.h                 |   42 +-
 modules/gui/macosx/SharedDialogs.m                 |   76 ++-
 modules/gui/macosx/VideoEffects.h                  |    6 +
 modules/gui/macosx/VideoEffects.m                  |   39 +-
 12 files changed, 915 insertions(+), 594 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=4da13fbc669110b24a4e3b541c91dd97304d6eac


More information about the vlc-commits mailing list