[vlc-commits] macosx: TextfieldPanel: change result handling from delegate to block

David Fuhrmann git at videolan.org
Tue Aug 11 10:24:21 CEST 2015


vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Tue Aug 11 09:42:03 2015 +0200| [2609901edfe4f615eef778b0b46c4ffdc5da5f88] | committer: David Fuhrmann

macosx: TextfieldPanel: change result handling from delegate to block

The former delegate approach had some drawbacks as one class could
be only delegate for one panel. This commit replaces it with a
completion handler block which moves the result handling code
closer to the actual creation of the dialog.

Also fixes crash for eq panels.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=2609901edfe4f615eef778b0b46c4ffdc5da5f88
---

 modules/gui/macosx/AudioEffects.m   |  156 +++++++++++++++++------------------
 modules/gui/macosx/ConvertAndSave.h |    1 -
 modules/gui/macosx/ConvertAndSave.m |   54 ++++++------
 modules/gui/macosx/SharedDialogs.h  |   20 +++--
 modules/gui/macosx/SharedDialogs.m  |   26 +++---
 modules/gui/macosx/VideoEffects.m   |   74 ++++++++---------
 6 files changed, 160 insertions(+), 171 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=2609901edfe4f615eef778b0b46c4ffdc5da5f88


More information about the vlc-commits mailing list