[vlc-commits] macosx: Split GoToTime panel into separate xib and window controller

[David Fuhrmann]

vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Tue Aug 11 15:20:02 2015 +0200| [ffe31745fc135c972b7eb0ec6366df2bffdfcb7d] | committer: David Fuhrmann

macosx: Split GoToTime panel into separate xib and window controller

This improves separation between main menu and the unrelated goto
time window.

Besides that, note that each time bindings are used with the file
owner, this owner needs to be an NSWindowController class. Only in
this case retain cycles are avoided (bindings have a strong
reference to the object used).

Thus, this commit helps to properly deinitialize the VLCMain object.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ffe31745fc135c972b7eb0ec6366df2bffdfcb7d
---

 Makefile.am                                        |    1 +
 .../macosx/Resources/English.lproj/MainMenu.xib    |   89 +----------------
 .../Resources/English.lproj/TimeSelectionPanel.xib |  101 ++++++++++++++++++++
 .../package/macosx/vlc.xcodeproj/project.pbxproj   |   18 ++++
 modules/gui/macosx/MainMenu.h                      |    9 --
 modules/gui/macosx/MainMenu.m                      |   76 +++++----------
 modules/gui/macosx/Makefile.am                     |    1 +
 .../gui/macosx/VLCTimeSelectionPanelController.h   |   53 ++++++++++
 .../gui/macosx/VLCTimeSelectionPanelController.m   |   98 +++++++++++++++++++
 po/POTFILES.in                                     |    2 +
 10 files changed, 304 insertions(+), 144 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=ffe31745fc135c972b7eb0ec6366df2bffdfcb7d