[vlc-commits] url: remove vlc_UrlParse() option parameter

Rémi Denis-Courmont git at videolan.org
Thu Aug 27 20:38:21 CEST 2015


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Thu Aug 27 21:22:25 2015 +0300| [d7a88fe038a9a1d56773d576365d4f6243f4d450] | committer: Rémi Denis-Courmont

url: remove vlc_UrlParse() option parameter

That parameter assumed that the query was part of the path. However it
is not, which leads to invalid host name, and eventually failure when
the path is missing. In practice, passing any value other than '?' as
separator would not work properly.

Remaining vlc_UrlParse() call sites without the option separator do not
support query at the protocol level anyway, so they are unaffected by the
change.

Signed-off-by: Rémi Denis-Courmont <remi at remlab.net>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=d7a88fe038a9a1d56773d576365d4f6243f4d450
---

 include/vlc_url.h                       |    2 +-
 modules/access/dsm/access.c             |    2 +-
 modules/access/ftp.c                    |    2 +-
 modules/access/gnomevfs.c               |    2 +-
 modules/access/http.c                   |    4 ++--
 modules/access/live555.cpp              |    2 +-
 modules/access/mms/mmsh.c               |    6 +++---
 modules/access/mms/mmstu.c              |    2 +-
 modules/access/rdp.c                    |    2 +-
 modules/access/sftp.c                   |    2 +-
 modules/access/vnc.c                    |    2 +-
 modules/access_output/shout.c           |    2 +-
 modules/control/oldrc.c                 |    2 +-
 modules/demux/adaptative/http/Chunk.cpp |    2 +-
 modules/lua/intf.c                      |    2 +-
 modules/lua/libs/net.c                  |    3 +--
 modules/misc/audioscrobbler.c           |    2 +-
 modules/misc/rtsp.c                     |    2 +-
 modules/services_discovery/upnp.cpp     |    4 ++--
 modules/stream_out/rtp.c                |    2 +-
 modules/stream_out/vod.c                |    2 +-
 share/lua/README.txt                    |    2 +-
 src/input/item.c                        |    2 +-
 src/network/httpd.c                     |    2 +-
 src/test/url.c                          |    2 +-
 src/text/url.c                          |   15 +++++----------
 26 files changed, 34 insertions(+), 40 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=d7a88fe038a9a1d56773d576365d4f6243f4d450


More information about the vlc-commits mailing list