[vlc-commits] mmal/codec: Enable error_concealment for h264

[Julian Scheel]

vlc | branch: master | Julian Scheel <julian at jusst.de> | Mon Jan 19 11:30:33 2015 +0100| [f870bdc6803650977a6833b2ff7d118b84719eda] | committer: Rémi Denis-Courmont

mmal/codec: Enable error_concealment for h264

Until now error concealment was disabled for h264 decoding because the mmal
h264 decoder did not properly parse SEI so that depending on the stream it
could happen that no valid picture would be detected at all and therefore no
picture would be shown at all. Latest raspberry firmware fixed this, so that
error concealment works properly and can be enabled.

Signed-off-by: Julian Scheel <julian at jusst.de>
Signed-off-by: Rémi Denis-Courmont <remi at remlab.net>

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f870bdc6803650977a6833b2ff7d118b84719eda
---

 modules/hw/mmal/codec.c |    9 ---------
 1 file changed, 9 deletions(-)

diff --git a/modules/hw/mmal/codec.c b/modules/hw/mmal/codec.c
index 497149f..3204def 100644
--- a/modules/hw/mmal/codec.c
+++ b/modules/hw/mmal/codec.c
@@ -97,7 +97,6 @@ static int OpenDecoder(decoder_t *dec)
 {
     int ret = VLC_SUCCESS;
     decoder_sys_t *sys;
-    MMAL_PARAMETER_BOOLEAN_T error_concealment;
     MMAL_PARAMETER_UINT32_T extra_buffers;
     MMAL_STATUS_T status;
 
@@ -155,14 +154,6 @@ static int OpenDecoder(decoder_t *dec)
                 msg_Err(dec, "Failed to allocate extra format data on input port %s (status=%"PRIx32" %s)",
                         sys->input->name, status, mmal_status_to_string(status));
             }
-        } else {
-            error_concealment.hdr.id = MMAL_PARAMETER_VIDEO_DECODE_ERROR_CONCEALMENT;
-            error_concealment.hdr.size = sizeof(MMAL_PARAMETER_BOOLEAN_T);
-            error_concealment.enable = MMAL_FALSE;
-            status = mmal_port_parameter_set(sys->input, &error_concealment.hdr);
-            if (status != MMAL_SUCCESS)
-                msg_Err(dec, "Failed to disable error concealment (status=%"PRIx32" %s)",
-                        status, mmal_status_to_string(status));
         }
     }