[vlc-commits] subpicture: Fix double free

[Hugo Beauzée-Luyssen]

vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Tue Jul 21 10:48:00 2015 +0200| [838e1e07f8a6059be29aa36e11765f71011c5333] | committer: Jean-Baptiste Kempf

subpicture: Fix double free

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=838e1e07f8a6059be29aa36e11765f71011c5333
---

 src/misc/subpicture.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/misc/subpicture.c b/src/misc/subpicture.c
index 19db482..998c52e 100644
--- a/src/misc/subpicture.c
+++ b/src/misc/subpicture.c
@@ -246,9 +246,8 @@ void subpicture_region_Delete( subpicture_region_t *p_region )
     if( p_region->p_picture )
         picture_Release( p_region->p_picture );
 
+    // Don't release text_segment's, they are owned by the subpicture itself
     free( p_region->fmt.p_palette );
-
-    text_segment_ChainDelete( p_region->p_text );
     free( p_region );
 }