[vlc-commits] mms: remove bogus sleeps

Rémi Denis-Courmont git at videolan.org
Wed Jun 3 22:11:05 CEST 2015


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Wed Jun  3 23:05:28 2015 +0300| [7eb623f3687b6cb108205b7ca0150d0082dabcc3] | committer: Rémi Denis-Courmont

mms: remove bogus sleeps

The NetFillBuffer() functions already waits (somewhat more correctly)
for events. If the error is due to parsing error, waiting longer will
not fix it. If the error is due to network timeout, then
NetFillBuffer() is already fine.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=7eb623f3687b6cb108205b7ca0150d0082dabcc3
---

 modules/access/mms/mmstu.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/modules/access/mms/mmstu.c b/modules/access/mms/mmstu.c
index 48b2723..4c974c4 100644
--- a/modules/access/mms/mmstu.c
+++ b/modules/access/mms/mmstu.c
@@ -1451,7 +1451,6 @@ static int mms_ReceiveCommand( access_t *p_access )
 }
 
 #define MMS_RETRY_MAX       10
-#define MMS_RETRY_SLEEP     50000
 
 static int mms_CommandRead( access_t *p_access, int i_command1,
                             int i_command2 )
@@ -1466,7 +1465,6 @@ static int mms_CommandRead( access_t *p_access, int i_command1,
         if( i_status < 0 || p_sys->i_command == 0 )
         {
             i_count++;
-            msleep( MMS_RETRY_SLEEP );
         }
         else if( i_command1 == 0 && i_command2 == 0)
         {
@@ -1519,7 +1517,6 @@ static int mms_HeaderMediaRead( access_t *p_access, int i_type )
             i_count++;
             msg_Warn( p_access, "cannot receive header (%d/%d)",
                       i_count, MMS_RETRY_MAX );
-            msleep( MMS_RETRY_SLEEP );
         }
         else if( i_status == i_type || i_type == MMS_PACKET_ANY )
         {



More information about the vlc-commits mailing list