[vlc-commits] macosx: fix main menu initialization order on startup

David Fuhrmann git at videolan.org
Sat Mar 21 18:32:20 CET 2015


vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Sat Mar 21 18:30:21 2015 +0100| [34e54feea7de9f75e6b2085df4a12235a516571a] | committer: David Fuhrmann

macosx: fix main menu initialization order on startup

MainMenus p_intf can be already accessed before
applicationWillFinishLaunching was called.

This should fix quite some crashes reported by the users.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=34e54feea7de9f75e6b2085df4a12235a516571a
---

 modules/gui/macosx/MainMenu.m |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/modules/gui/macosx/MainMenu.m b/modules/gui/macosx/MainMenu.m
index 3c678e3..9593ad7 100644
--- a/modules/gui/macosx/MainMenu.m
+++ b/modules/gui/macosx/MainMenu.m
@@ -139,12 +139,12 @@ static VLCMainMenu *_o_sharedInstance = nil;
     }
 
     [self setRateControlsEnabled:NO];
+
+    p_intf = VLCIntf;
 }
 
 - (void)applicationWillFinishLaunching:(NSNotification *)o_notification
 {
-    p_intf = VLCIntf;
-
     NSString* o_key;
     playlist_t *p_playlist;
     vlc_value_t val;



More information about the vlc-commits mailing list