[vlc-commits] Win32: Fix supported types not registered properly by NSIS installer

Jonathan McGowan git at videolan.org
Wed Mar 25 15:17:51 CET 2015


vlc/vlc-2.2 | branch: master | Jonathan McGowan <jonathan at howlingwolf.org.uk> | Mon Mar 16 11:43:54 2015 +0000| [9d9b2bf7da2d756bddaae5863aa5fa4e1320fb4e] | committer: Jean-Baptiste Kempf

Win32: Fix supported types not registered properly by NSIS installer

A bad parameter definition in function RegisterExtension resulted in the same value entry being written every time ("${EXT}"="").

Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>
(cherry picked from commit 506b7918936d668d221f79b9e926cf96c32c5005)
Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.2.git/?a=commit;h=9d9b2bf7da2d756bddaae5863aa5fa4e1320fb4e
---

 extras/package/win32/NSIS/helpers/extensions.nsh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/extras/package/win32/NSIS/helpers/extensions.nsh b/extras/package/win32/NSIS/helpers/extensions.nsh
index 2bb22c7..4b15136 100644
--- a/extras/package/win32/NSIS/helpers/extensions.nsh
+++ b/extras/package/win32/NSIS/helpers/extensions.nsh
@@ -21,7 +21,7 @@ Function RegisterExtension
   WriteRegStr HKCR "VLC$R0\shell\Open" "MultiSelectModel" "Player"
   WriteRegStr HKCR "VLC$R0\shell\Open\command" "" '"$INSTDIR\vlc.exe" --started-from-file "%1"'
   WriteRegStr HKCR "VLC$R0\DefaultIcon" "" '"$INSTDIR\vlc.exe",0'
-  WriteRegStr HKCR "Applications\vlc.exe\SupportedTypes" ${EXT} ""
+  WriteRegStr HKCR "Applications\vlc.exe\SupportedTypes" $0 ""
 
   ${If} ${AtLeastWinVista}
     WriteRegStr HKLM "Software\Clients\Media\VLC\Capabilities\FileAssociations" "$R0" "VLC$R0"



More information about the vlc-commits mailing list