[vlc-commits] demux: mp4: fix uninitialized struct members

Francois Cartegnie git at videolan.org
Tue May 5 23:59:26 CEST 2015


vlc | branch: master | Francois Cartegnie <fcvlcdev at free.fr> | Tue May  5 23:54:00 2015 +0200| [0dbd2998f5fef995654c6af36922ae67008272e0] | committer: Francois Cartegnie

demux: mp4: fix uninitialized struct members

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=0dbd2998f5fef995654c6af36922ae67008272e0
---

 modules/demux/mp4/libmp4.c |   10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/modules/demux/mp4/libmp4.c b/modules/demux/mp4/libmp4.c
index b88273b..140b290 100644
--- a/modules/demux/mp4/libmp4.c
+++ b/modules/demux/mp4/libmp4.c
@@ -4091,23 +4091,15 @@ MP4_Box_t *MP4_BoxGetRoot( stream_t *s )
     stream_t *p_stream;
     int i_result;
 
-    p_root = malloc( sizeof( MP4_Box_t ) );
+    p_root = calloc( 1, sizeof( MP4_Box_t ) );
     if( p_root == NULL )
         return NULL;
 
-    p_root->i_pos = 0;
     p_root->i_type = ATOM_root;
     p_root->i_shortsize = 1;
     /* could be a DASH stream for exemple, 0 means unknown or infinite size */
-    p_root->i_size = 0;
     CreateUUID( &p_root->i_uuid, p_root->i_type );
 
-    p_root->data.p_payload = NULL;
-    p_root->p_father    = NULL;
-    p_root->p_first     = NULL;
-    p_root->p_last      = NULL;
-    p_root->p_next      = NULL;
-
     p_stream = s;
 
     /* First get the moov */



More information about the vlc-commits mailing list