[vlc-commits] AudioBar: do not put default values in help string

Jean-Baptiste Kempf git at videolan.org
Fri May 8 14:20:27 CEST 2015


vlc | branch: master | Jean-Baptiste Kempf <jb at videolan.org> | Fri May  8 14:20:00 2015 +0200| [16acc6a95c25a5a9b68be27d4e605dc497aa37e1] | committer: Jean-Baptiste Kempf

AudioBar: do not put default values in help string

This is a bad idea.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=16acc6a95c25a5a9b68be27d4e605dc497aa37e1
---

 modules/video_filter/audiobargraph_v.c |   10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/modules/video_filter/audiobargraph_v.c b/modules/video_filter/audiobargraph_v.c
index 13e7261..1a28373 100644
--- a/modules/video_filter/audiobargraph_v.c
+++ b/modules/video_filter/audiobargraph_v.c
@@ -53,12 +53,10 @@
   "Enforce the bargraph position on the video " \
   "(0=center, 1=left, 2=right, 4=top, 8=bottom, you can " \
   "also use combinations of these values, eg 6 = top-right).")
-#define BARWIDTH_TEXT N_("Bar width in pixel (default : 10)")
-#define BARWIDTH_LONGTEXT N_("Width in pixel of each bar in the BarGraph to be displayed " \
-                "(default : 10).")
-#define BARHEIGHT_TEXT N_("Bar Height in pixel (default : 400)")
-#define BARHEIGHT_LONGTEXT N_("Height in pixel of BarGraph to be displayed " \
-                "(default : 400).")
+#define BARWIDTH_TEXT N_("Bar width in pixel")
+#define BARWIDTH_LONGTEXT N_("Width in pixel of each bar in the BarGraph to be displayed." )
+#define BARHEIGHT_TEXT N_("Bar Height in pixel")
+#define BARHEIGHT_LONGTEXT N_("Height in pixel of BarGraph to be displayed." )
 
 #define CFG_PREFIX "audiobargraph_v-"
 



More information about the vlc-commits mailing list