[vlc-commits] taglib: fix memory leak

Rémi Denis-Courmont git at videolan.org
Wed Oct 21 18:45:25 CEST 2015


vlc/vlc-2.2 | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Aug 22 10:46:17 2015 +0300| [fcf65db177682ea042bf69997643b66628bfc2d1] | committer: Jean-Baptiste Kempf

taglib: fix memory leak

(cherry picked from commit 18a676c9e06fa1407b525b3c2337ada788aa06e8)
Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.2.git/?a=commit;h=fcf65db177682ea042bf69997643b66628bfc2d1
---

 modules/meta_engine/taglib.cpp |    1 +
 1 file changed, 1 insertion(+)

diff --git a/modules/meta_engine/taglib.cpp b/modules/meta_engine/taglib.cpp
index f0c382e..669ff34 100644
--- a/modules/meta_engine/taglib.cpp
+++ b/modules/meta_engine/taglib.cpp
@@ -566,6 +566,7 @@ static void ReadMetaFromXiph( Ogg::XiphComment* tag, demux_meta_t* p_demux_meta,
         /* TODO: Use i_cover_score / i_cover_idx to select the picture. */
         p_attachment = ParseFlacPicture( p_data, i_data, 0,
             &i_cover_score, &i_cover_idx );
+        free( p_data );
     }
 
     TAB_INIT( p_demux_meta->i_attachments, p_demux_meta->attachments );



More information about the vlc-commits mailing list