[vlc-commits] input/item: factor input_item_t New*() functions

[Thomas Guillem]

vlc | branch: master | Thomas Guillem <thomas at gllm.fr> | Thu Apr 14 11:16:24 2016 +0200| [e49ee59ad95de6173c3b287b47189c00b7f43b84] | committer: Thomas Guillem

input/item: factor input_item_t New*() functions

Remove "int options, const char *const *options, unsigned option_flags"
arguments from every New() functions since these args are mainly unused. You
now have to call input_item_AddOptions after input item creation to add
options.

Add input_item_net_type enum in order to avoid confusion between 2 int
arguments: i_duration and i_net that could both be -1, 0 or > 0.

Replace input_item_NewWithType and input_item_NewWithTypeExt with
input_item_NewExt.

Add input_item_NewCard, input_item_NewDisc, input_item_NewStream,
input_item_NewDirectory, input_item_NewFile MACRO. These MACROS avoid to use
useless arguments for an item type (for example, it's useless to specify a
duration for a directory type).

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=e49ee59ad95de6173c3b287b47189c00b7f43b84
---

 include/vlc_input_item.h              |   51 +++++++++++++++++----------------
 lib/media_list.c                      |    3 +-
 modules/access/cdda.c                 |    6 ++--
 modules/access/directory.c            |    4 +--
 modules/access/dsm/access.c           |    3 +-
 modules/access/dsm/sd.c               |    3 +-
 modules/access/ftp.c                  |    4 +--
 modules/access/nfs.c                  |    8 ++----
 modules/access/sftp.c                 |    3 +-
 modules/access/smb.c                  |    4 +--
 modules/demux/playlist/asx.c          |    7 +++--
 modules/demux/playlist/dvb.c          |    7 ++---
 modules/demux/playlist/m3u.c          |    5 ++--
 modules/demux/playlist/ram.c          |    4 ++-
 modules/demux/playlist/sgimb.c        |    4 +--
 modules/demux/playlist/wpl.c          |    2 +-
 modules/demux/playlist/xspf.c         |    5 ++--
 modules/lua/libs/sd.c                 |   28 +++++++++---------
 modules/lua/vlc.c                     |    9 +++---
 modules/services_discovery/bonjour.m  |    7 ++---
 modules/services_discovery/microdns.c |    3 +-
 modules/services_discovery/os2drive.c |    2 +-
 modules/services_discovery/pulse.c    |    4 +--
 modules/services_discovery/sap.c      |    5 ++--
 modules/services_discovery/udev.c     |    5 ++--
 modules/services_discovery/upnp.cpp   |   16 +++++------
 modules/services_discovery/windrive.c |    3 +-
 modules/services_discovery/xcb_apps.c |    7 ++---
 src/input/item.c                      |   44 +++++++---------------------
 src/libvlccore.sym                    |    2 --
 src/playlist/item.c                   |    6 ++--
 src/playlist/loadsave.c               |    4 +--
 src/playlist/tree.c                   |    4 +--
 33 files changed, 118 insertions(+), 154 deletions(-)

Diff:   http://git.videolan.org/gitweb.cgi/vlc.git/?a=commitdiff;h=e49ee59ad95de6173c3b287b47189c00b7f43b84