[vlc-commits] macosx: Fix warning about incorrect usage of negator

David Fuhrmann git at videolan.org
Sat Apr 23 10:53:38 CEST 2016


vlc | branch: master | David Fuhrmann <dfuhrmann at videolan.org> | Sat Apr 23 10:50:32 2016 +0200| [88b85b54fc0e65b4cdafa2d43cd5fd6283d61bcb] | committer: David Fuhrmann

macosx: Fix warning about incorrect usage of negator

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=88b85b54fc0e65b4cdafa2d43cd5fd6283d61bcb
---

 modules/gui/macosx/ConvertAndSave.m |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/modules/gui/macosx/ConvertAndSave.m b/modules/gui/macosx/ConvertAndSave.m
index c93ee0a..5162350 100644
--- a/modules/gui/macosx/ConvertAndSave.m
+++ b/modules/gui/macosx/ConvertAndSave.m
@@ -526,21 +526,21 @@
     [_streamDestinationURLLabel setStringValue:labelContent];
 
     /* catch obvious errors */
-    if (![[_streamAddressField stringValue] length] > 0) {
+    if ([[_streamAddressField stringValue] length] == 0) {
         NSBeginInformationalAlertSheet(_NS("No Address given"),
                                        _NS("OK"), @"", @"", _streamPanel, nil, nil, nil, nil,
                                        @"%@", _NS("In order to stream, a valid destination address is required."));
         return;
     }
 
-    if ([_streamSAPCheckbox state] && ![[_streamChannelField stringValue] length] > 0) {
+    if ([_streamSAPCheckbox state] && [[_streamChannelField stringValue] length] == 0) {
         NSBeginInformationalAlertSheet(_NS("No Channel Name given"),
                                        _NS("OK"), @"", @"", _streamPanel, nil, nil, nil, nil,
                                        @"%@", _NS("SAP stream announcement is enabled. However, no channel name is provided."));
         return;
     }
 
-    if ([_streamSDPMatrix isEnabled] && [_streamSDPMatrix selectedCell] != [_streamSDPMatrix cellWithTag:0] && ![[_streamSDPField stringValue] length] > 0) {
+    if ([_streamSDPMatrix isEnabled] && [_streamSDPMatrix selectedCell] != [_streamSDPMatrix cellWithTag:0] && [[_streamSDPField stringValue] length] == 0) {
         NSBeginInformationalAlertSheet(_NS("No SDP URL given"),
                                        _NS("OK"), @"", @"", _streamPanel, nil, nil, nil, nil,
                                        @"%@", _NS("A SDP export is requested, but no URL is provided."));



More information about the vlc-commits mailing list