[vlc-commits] XCB/XVideo: ignore the overlay setting

[Rémi Denis-Courmont]

vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Apr 30 18:50:55 2016 +0300| [de6f4b31ef6a9eb1cf744bbb8ed600ebb0ac9db0] | committer: Rémi Denis-Courmont

XCB/XVideo: ignore the overlay setting

XVideo version 2 does not provide visiblity or control over the use
of hardware video overlays. That is an implementation detail of the
X11 driver. Thus the overlay setting did not really work as advertized.
The XVideo adapter setting has to be used instead.

In fact most drivers still in use today do not use overlay, but
the 3D engine (either via vendor-specific support or via GLAMOR). And
since the XVideo plugin got lower priority than VDPAU and OpenGL, the
setting has been redundant: it only has effects if neither VDPAU nor
OpenGL are supported (!), and even --no-overlay has the same results
as --vout=x11.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=de6f4b31ef6a9eb1cf744bbb8ed600ebb0ac9db0
---

 modules/video_output/xcb/xvideo.c |    3 ---
 1 file changed, 3 deletions(-)

diff --git a/modules/video_output/xcb/xvideo.c b/modules/video_output/xcb/xvideo.c
index 83fcbf3..b487297 100644
--- a/modules/video_output/xcb/xvideo.c
+++ b/modules/video_output/xcb/xvideo.c
@@ -355,9 +355,6 @@ static int Open (vlc_object_t *obj)
     vout_display_t *vd = (vout_display_t *)obj;
     vout_display_sys_t *p_sys;
 
-    if (!var_InheritBool (obj, "overlay"))
-        return VLC_EGENERIC;
-    else
     {   /* NOTE: Reject hardware surface formats. Blending would break. */
         const vlc_chroma_description_t *chroma =
             vlc_fourcc_GetChromaDescription(vd->source.i_chroma);