[vlc-commits] qt: controller: Don't connect the controller and MIM in a loop

Hugo Beauzée-Luyssen git at videolan.org
Tue Dec 27 19:07:37 CET 2016


vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Tue Dec 27 18:34:04 2016 +0100| [eea941425cc9a463841042627bf9d52ef1979a1c] | committer: Hugo Beauzée-Luyssen

qt: controller: Don't connect the controller and MIM in a loop

This ends up connecting the 2 way too many times

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=eea941425cc9a463841042627bf9d52ef1979a1c
---

 modules/gui/qt/components/controller.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/modules/gui/qt/components/controller.cpp b/modules/gui/qt/components/controller.cpp
index cffad74..0d2f49a 100644
--- a/modules/gui/qt/components/controller.cpp
+++ b/modules/gui/qt/components/controller.cpp
@@ -837,6 +837,8 @@ FullscreenControllerWidget::FullscreenControllerWidget( intf_thread_t *_p_i, QWi
     screenRes = getSettings()->value( "FullScreen/screen" ).toRect();
     isWideFSC = getSettings()->value( "FullScreen/wide" ).toBool();
     i_screennumber = var_InheritInteger( p_intf, "qt-fullscreen-screennumber" );
+
+    CONNECT( this, fullscreenChanged( bool ), THEMIM, changeFullscreen( bool ) );
 }
 
 FullscreenControllerWidget::~FullscreenControllerWidget()
@@ -1185,7 +1187,6 @@ void FullscreenControllerWidget::setVoutList( vout_thread_t **pp_vout, int i_vou
         vout.append( p_vout );
         var_AddCallback( p_vout, "fullscreen",
                          FullscreenControllerWidgetFullscreenChanged, this );
-	CONNECT( this, fullscreenChanged( bool ), THEMIM, changeFullscreen( bool ) );
         /* I miss a add and fire */
         fullscreenChanged( p_vout, var_GetBool( p_vout, "fullscreen" ),
                            var_GetInteger( p_vout, "mouse-hide-timeout" ) );



More information about the vlc-commits mailing list