[vlc-commits] main_interface_win32: Fix play/pause button not being updated

Hugo Beauzée-Luyssen git at videolan.org
Wed Dec 28 17:00:06 CET 2016


vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Wed Dec 28 16:58:31 2016 +0100| [f5c22a203af47f2dbebdab62078f2545d56692b1] | committer: Hugo Beauzée-Luyssen

main_interface_win32: Fix play/pause button not being updated

The buttons are created upon the main intf winID, so we need to update
the buttons with the same winID as parameter

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=f5c22a203af47f2dbebdab62078f2545d56692b1
---

 modules/gui/qt/main_interface_win32.cpp | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/modules/gui/qt/main_interface_win32.cpp b/modules/gui/qt/main_interface_win32.cpp
index 00a840a..211fc7e 100644
--- a/modules/gui/qt/main_interface_win32.cpp
+++ b/modules/gui/qt/main_interface_win32.cpp
@@ -113,7 +113,6 @@ void MainInterface::createTaskBarButtons()
 {
     /*Here is the code for the taskbar thumb buttons
     FIXME:We need pretty buttons in 16x16 px that are handled correctly by masks in Qt
-    FIXME:the play button's picture doesn't changed to pause when clicked
     */
     p_taskbl = NULL;
     himl = NULL;
@@ -349,11 +348,7 @@ void MainInterface::changeThumbbarButtons( int i_status )
             return;
     }
 
-    HRESULT hr;
-    if( videoWidget && THEMIM->getIM()->hasVideo() )
-        hr =  p_taskbl->ThumbBarUpdateButtons(WinId(videoWidget), 3, thbButtons);
-    else
-        hr =  p_taskbl->ThumbBarUpdateButtons(WinId(this), 3, thbButtons);
+    HRESULT hr =  p_taskbl->ThumbBarUpdateButtons(WinId(this), 3, thbButtons);
 
     if(S_OK != hr)
         msg_Err( p_intf, "ThumbBarUpdateButtons failed with error %08lx", hr );



More information about the vlc-commits mailing list