[vlc-commits] main_interface_win32: Fix play/pause button not being updated

Hugo Beauzée-Luyssen git at videolan.org
Wed Dec 28 22:11:32 CET 2016


vlc/vlc-2.2 | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Wed Dec 28 16:58:31 2016 +0100| [44e33d774da1bf3007a81ac1df8a182c7ac1ab45] | committer: Jean-Baptiste Kempf

main_interface_win32: Fix play/pause button not being updated

The buttons are created upon the main intf winID, so we need to update
the buttons with the same winID as parameter

(cherry picked from commit 0f9a6c411211a69210f4e34882ac59c749f1c29b)
Signed-off-by: Jean-Baptiste Kempf <jb at videolan.org>

> http://git.videolan.org/gitweb.cgi/vlc/vlc-2.2.git/?a=commit;h=44e33d774da1bf3007a81ac1df8a182c7ac1ab45
---

 modules/gui/qt4/main_interface_win32.cpp | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/modules/gui/qt4/main_interface_win32.cpp b/modules/gui/qt4/main_interface_win32.cpp
index e4aed42..d7bc4f1 100644
--- a/modules/gui/qt4/main_interface_win32.cpp
+++ b/modules/gui/qt4/main_interface_win32.cpp
@@ -112,7 +112,6 @@ void MainInterface::createTaskBarButtons()
 {
     /*Here is the code for the taskbar thumb buttons
     FIXME:We need pretty buttons in 16x16 px that are handled correctly by masks in Qt
-    FIXME:the play button's picture doesn't changed to pause when clicked
     */
     p_taskbl = NULL;
     himl = NULL;
@@ -350,11 +349,7 @@ void MainInterface::changeThumbbarButtons( int i_status )
             return;
     }
 
-    HRESULT hr;
-    if( videoWidget && THEMIM->getIM()->hasVideo() )
-        hr =  p_taskbl->ThumbBarUpdateButtons(WinId(videoWidget), 3, thbButtons);
-    else
-        hr =  p_taskbl->ThumbBarUpdateButtons(WinId(this), 3, thbButtons);
+    HRESULT hr =  p_taskbl->ThumbBarUpdateButtons(WinId(this), 3, thbButtons);
 
     if(S_OK != hr)
         msg_Err( p_intf, "ThumbBarUpdateButtons failed with error %08lx", hr );



More information about the vlc-commits mailing list