[vlc-commits] http: explicitly allow deflate & gzip encoding in live streams

Rémi Denis-Courmont git at videolan.org
Mon Feb 1 22:08:24 CET 2016


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Mon Feb  1 23:03:04 2016 +0200| [9f4a3ba201af0e400c3f1265597756ca17966ecd] | committer: Rémi Denis-Courmont

http: explicitly allow deflate & gzip encoding in live streams

This explicitly allows the server to return gzip or deflate
Content-Encoding.

This is not explicitly allowed for normal streams because
Content-Encoding breaks use of bytes ranges. Seeking offsets and size
would be in terms of the compressed stream. This would prevent VLC
demuxers from seeking or estimating duration.

The HTTP origin server can still return Content-Encoding in any case as
VLC does not explicitly forbid it (with Accept-Encoding: identity).
However in practice, servers will not perform opportunistic on-the-fly
compression.

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=9f4a3ba201af0e400c3f1265597756ca17966ecd
---

 modules/access/http/live.c |    4 ----
 1 file changed, 4 deletions(-)

diff --git a/modules/access/http/live.c b/modules/access/http/live.c
index bc10498..a1f44cd 100644
--- a/modules/access/http/live.c
+++ b/modules/access/http/live.c
@@ -40,11 +40,7 @@ struct vlc_http_live
 static int vlc_http_live_req(struct vlc_http_msg *req,
                              const struct vlc_http_resource *res, void *opaque)
 {
-#if 0 // TODO
     vlc_http_msg_add_header(req, "Accept-Encoding", "gzip, deflate");
-#else
-    (void) req;
-#endif
     (void) res;
     (void) opaque;
     return 0;



More information about the vlc-commits mailing list