[vlc-commits] dvdnav: Fix use after free

[Hugo Beauzée-Luyssen]

vlc | branch: master | Hugo Beauzée-Luyssen <hugo at beauzee.fr> | Mon Feb 22 10:49:35 2016 +0100| [b92f0136863f1e53c8bc17424d5c72fc358887a5] | committer: Hugo Beauzée-Luyssen

dvdnav: Fix use after free

Using an unsigned value makes it impossible to detect errors, which
leads to reading from a freed buffer

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=b92f0136863f1e53c8bc17424d5c72fc358887a5
---

 modules/access/dvdnav.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/modules/access/dvdnav.c b/modules/access/dvdnav.c
index fc3c60b..884c04f 100644
--- a/modules/access/dvdnav.c
+++ b/modules/access/dvdnav.c
@@ -404,7 +404,7 @@ bailout:
 static int StreamProbeDVD( stream_t *s )
 {
     /* first sector should be filled with zeros */
-    size_t i_peek;
+    ssize_t i_peek;
     const uint8_t *p_peek;
     i_peek = stream_Peek( s, &p_peek, 2048 );
     if( i_peek < 512 ) {