[vlc-commits] Revert "video_filter: hqdn3d: reject computed height <= 0 (cid #718140)"

Rémi Denis-Courmont git at videolan.org
Sat Jan 2 19:55:31 CET 2016


vlc | branch: master | Rémi Denis-Courmont <remi at remlab.net> | Sat Jan  2 20:51:56 2016 +0200| [ecfc51d4783960aca8d3c92fd33c080a6bdf41bd] | committer: Rémi Denis-Courmont

Revert "video_filter: hqdn3d: reject computed height <= 0 (cid #718140)"

This reverts commit 6c5c07b96b1a349fe76473a84e8b561522bcea4d.
This made no sense. Picture dimensions cannot be zero or less (besides
the buffer is not used by the denoise function even then).

> http://git.videolan.org/gitweb.cgi/vlc.git/?a=commit;h=ecfc51d4783960aca8d3c92fd33c080a6bdf41bd
---

 modules/video_filter/hqdn3d.c |    6 ------
 1 file changed, 6 deletions(-)

diff --git a/modules/video_filter/hqdn3d.c b/modules/video_filter/hqdn3d.c
index 4d48a96..41196be 100644
--- a/modules/video_filter/hqdn3d.c
+++ b/modules/video_filter/hqdn3d.c
@@ -136,12 +136,6 @@ static int Open(vlc_object_t *this)
         sys->w[i] = fmt_in->i_width  * chroma->p[i].w.num / chroma->p[i].w.den;
         if (sys->w[i] > wmax) wmax = sys->w[i];
         sys->h[i] = fmt_out->i_height * chroma->p[i].h.num / chroma->p[i].h.den;
-
-        if(sys->w[i] <= 0 || sys->h[i] <= 0)
-        {
-            free(sys);
-            return VLC_EGENERIC;
-        }
     }
     cfg->Line = malloc(wmax*sizeof(unsigned int));
     if (!cfg->Line) {



More information about the vlc-commits mailing list